Fix memory leaks when returning refcounted value from curl callback #18883
+48
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielEScherzer
requested changes
Jun 20, 2025
| curl | ||
| --FILE-- | ||
| <?php | ||
| include 'server.inc'; |
There was a problem hiding this comment.
All of the lines are indented with an extra space
There was a problem hiding this comment.
That's the style of some of the tests, I used another one as a basis but can drop the indent
There was a problem hiding this comment.
Oh, if it was intentional then nevermind, just thought it was from an IDE
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
DanielEScherzer
requested review from
DanielEScherzer
and removed request for
DanielEScherzer
DanielEScherzer
approved these changes
Jun 20, 2025
|
FWIW, it's possible to dismiss a review when going to the bottom of the page, clicking open the reviews under "1 requested changes" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.